Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: createAwsCognitoOAuthConfig() #311

Merged
merged 6 commits into from
Mar 18, 2024

Conversation

gdtroszak
Copy link
Contributor

Adds the configuration for a Cognito User Pool provider.

This assumes users have their user pool app client properly configured. Namely, it needs to have a client secret generated, have the appropriate callback URLs registered, and support the AuthorizationCodeGrant flow.

Resolves #310

Demo App Screenshots

Signed Out

Screenshot 2024-03-06 at 11 00 58 AM

Signed In

Screenshot 2024-03-06 at 11 01 18 AM

Copy link
Collaborator

@iuioiua iuioiua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should call this AWS Cognito. I.e. createAwsCognitoOAuthConfig(), AWS_COGNITO_CLIENT_ID, etc. WDYT?

@gdtroszak
Copy link
Contributor Author

I think we should call this AWS Cognito. I.e. createAwsCognitoOAuthConfig(), AWS_COGNITO_CLIENT_ID, etc. WDYT?

Works for me. I'll ping you when I make the change.

@gdtroszak
Copy link
Contributor Author

@iuioiua Naming updated!

Copy link
Collaborator

@iuioiua iuioiua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for this. Much appreciated.

@iuioiua iuioiua changed the title Add Cognito User Pool Provider feat: createAwsCognitoOAuthConfig() Mar 18, 2024
@iuioiua iuioiua merged commit fcc8068 into denoland:main Mar 18, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AWS Cognito provider?
2 participants