Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Helpers interface #313

Merged
merged 4 commits into from
Mar 20, 2024
Merged

feat: Helpers interface #313

merged 4 commits into from
Mar 20, 2024

Conversation

iuioiua
Copy link
Collaborator

@iuioiua iuioiua commented Mar 18, 2024

This change deprecates signIn(), handleCallback(), signOut(), and getSessionId() in favour of the functions created from createHelpers(). This ensures that the behaviour of helpers is consistent throughout various pages. The Helper interface will make the documentation of these functions easier to read.

Supercedes #312

Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@iuioiua iuioiua merged commit 49bfffb into main Mar 20, 2024
10 checks passed
@iuioiua iuioiua deleted the helpers branch March 20, 2024 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants