Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add no-import-assertions rule #1209

Merged
merged 3 commits into from
Nov 20, 2023
Merged

feat: add no-import-assertions rule #1209

merged 3 commits into from
Nov 20, 2023

Conversation

petamoriken
Copy link
Contributor

@petamoriken
Copy link
Contributor Author

Oh, we need to support dynamic imports

@petamoriken petamoriken marked this pull request as draft November 14, 2023 15:21
@petamoriken petamoriken marked this pull request as ready for review November 14, 2023 17:01
@petamoriken petamoriken changed the title feat: add no-import-assetions rule feat: add no-import-assertions rule Nov 14, 2023
@petamoriken
Copy link
Contributor Author

@magurotuna Please take a look!

dsherret
dsherret approved these changes Nov 20, 2023
View reviewed changes
Copy link
Member

@dsherret dsherret left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for adding this.

@dsherret dsherret merged commit 0bebdcd into denoland:main Nov 20, 2023
6 checks passed
@petamoriken petamoriken deleted the feat/no-import-assetions branch November 20, 2023 23:37
@magurotuna
Copy link
Member

Sorry I overlooked your notification @petamoriken, and thank you for reviewing David!

@iuioiua iuioiua mentioned this pull request Jan 10, 2024
Merged
@petamoriken petamoriken mentioned this pull request May 9, 2024
Open
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsherret dsherret dsherret approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@petamoriken @magurotuna @dsherret