Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add no-console to rules #1214

Merged
merged 2 commits into from
Nov 24, 2023
Merged

fix: add no-console to rules #1214

merged 2 commits into from
Nov 24, 2023

Conversation

dsherret
Copy link
Member

@dsherret dsherret commented Nov 24, 2023 •
edited

@dsherret dsherret mentioned this pull request Nov 24, 2023
Closed
bartlomieju
bartlomieju approved these changes Nov 24, 2023
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please update doc site before merging.

@dsherret dsherret merged commit b563057 into denoland:main Nov 24, 2023
6 checks passed
@dsherret dsherret deleted the no_console_log_rules branch November 24, 2023 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marvinhagemeister marvinhagemeister marvinhagemeister approved these changes

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dsherret @marvinhagemeister @bartlomieju