Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix control flow analysis on for statements #481

Merged
merged 9 commits into from Oct 30, 2020
Merged

fix control flow analysis on for statements #481

merged 9 commits into from Oct 30, 2020

Conversation

magurotuna
Copy link
Member

Fixes #477

bartlomieju
bartlomieju approved these changes Oct 30, 2020
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great fix @magurotuna

@bartlomieju bartlomieju merged commit 9f03d55 into denoland:master Oct 30, 2020
@magurotuna magurotuna deleted the no-unreachable-477 branch October 31, 2020 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

no-unreachable false positive
2 participants
@magurotuna @bartlomieju