Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(no-undef): handle hoisted class declarations #497

Merged
merged 5 commits into from Nov 3, 2020
Merged

fix(no-undef): handle hoisted class declarations #497

merged 5 commits into from Nov 3, 2020

Conversation

magurotuna
Copy link
Member

Fixes #463
Ref: #486

CC @kdy1 @bartlomieju

@magurotuna magurotuna mentioned this pull request Nov 3, 2020
Closed
kdy1
kdy1 approved these changes Nov 3, 2020
View reviewed changes
Copy link
Contributor

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

bartlomieju
bartlomieju approved these changes Nov 3, 2020
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice fix

@bartlomieju bartlomieju merged commit fada318 into denoland:master Nov 3, 2020
@magurotuna magurotuna deleted the fix/no-undef2 branch November 3, 2020 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

@kdy1 kdy1 kdy1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

no-undef false positive
3 participants
@magurotuna @bartlomieju @kdy1