Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(no-dupe-keys): deal with BigInt keys #541

Merged
merged 6 commits into from Nov 17, 2020
Merged

fix(no-dupe-keys): deal with BigInt keys #541

merged 6 commits into from Nov 17, 2020

Conversation

magurotuna
Copy link
Member

@magurotuna magurotuna commented Nov 17, 2020 •
edited

Thanks to swc-project/swc#1192, BigInt keys can be parsed correctly, which allows us to address a TODO comment in no-dupe-keys.

(EDIT) Plus addressed CI issues :)

bartlomieju
bartlomieju approved these changes Nov 17, 2020
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thanks!

@bartlomieju bartlomieju merged commit 468704a into denoland:master Nov 17, 2020
@magurotuna magurotuna deleted the address-todo-no-dupe-keys branch November 17, 2020 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@magurotuna @bartlomieju