Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: remove checking checksums from lockfile crate #25

Merged
merged 1 commit into from
May 27, 2024
Merged

feat: remove checking checksums from lockfile crate #25

merged 1 commit into from
May 27, 2024

Conversation

dsherret
Copy link
Member

This is now handled outside the lockfile crate.

  1. Checking npm checksums has been handled by deno_npm for a while.
  2. Checking other checksums is now handled by deno_graph providing checksums to the loader

@dsherret dsherret requested a review from bartlomieju May 27, 2024 22:34
@dsherret dsherret merged commit 163ee6b into denoland:main May 27, 2024
1 check passed
@dsherret dsherret deleted the feat_remove_lockfile_checksum_checking branch May 27, 2024 22:39
@dsherret dsherret mentioned this pull request May 27, 2024
Merged
dsherret added a commit to denoland/deno that referenced this pull request May 28, 2024
@dsherret
feat(vendor): support modifying remote files in vendor folder without…
448fe67 
… checksum errors (#23979)

Includes:

* denoland/deno_graph#486
* denoland/deno_graph#488
* denoland/deno_lockfile#25
* denoland/deno_lockfile#22
* denoland/deno_graph#483
* denoland/deno_graph#470
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dsherret @bartlomieju