Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: lockfile v3 #8

Merged
merged 7 commits into from
Sep 6, 2023
Merged

feat: lockfile v3 #8

merged 7 commits into from
Sep 6, 2023

Conversation

dsherret
Copy link
Member

@dsherret dsherret commented Aug 31, 2023

This is a proposal that has not yet been agreed upon.

  1. Moves npm -> specifiers to packages -> specifiers. Each specifier and destination is now prefixed with npm:.
    • This generalizes with deno: specifiers and allows mapping deno: specifiers to npm:.
  2. Moves npm -> packages to packages -> npm.

deno: specifiers will then be stored under packages -> specifiers.

Example output:

{
  "version": "3",
  "packages": {
    "specifiers": {
      "npm:nanoid": "npm:nanoid@3.3.4",
      "deno:path": "deno:@std/path@1.0.0",
      "deno:ts-morph@^11": "npm:ts-morph@11.0.0",
      "deno:@scope/pkg@~1.0": "deno:@scope/pkg@1.0.5"
    },
    "npm": {
      "nanoid@3.3.4": {
        "integrity": "sha512-MqBkQh/OHTS2egovRtLk45wEyNXwF+cokD+1YPf9u5VfJiRdAiRwB2froX5Co9Rh20xs4siNPm8naNotSD6RBw==",
        "dependencies": {}
      },
      "picocolors@1.0.0": {
        "integrity": "sha512-foobar",
        "dependencies": {}
      }
    }
  },
  "remote": {
    "https://github.com/": "MqBkQh/OHTS2egovRtLk45wEyNXwF+cokD+1YPf9u5VfJiRdAiRwB2froX5Co9Rh20xs4siNPm8naNotSD6RBw==",
    "https://github.com/mod.ts": "MqBkQh/OHTS2egovRtLk45wEyNXwF+cokD+1YPf9u5VfJiRdAiRwB2froX5Co9Rh20xs4siNPm8naNotSD6RBw=="
  }
}

Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I think it makes sense 👍

src/transforms.rs Show resolved Hide resolved
@dsherret dsherret merged commit 45fe515 into denoland:main Sep 6, 2023
1 check passed
@dsherret dsherret deleted the deno_specifiers branch September 6, 2023 15:52
dsherret added a commit to denoland/deno that referenced this pull request Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants