-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: reduce allocations in MediaType::from_specifier
#7
Merged
dsherret
merged 6 commits into
denoland:main
from
dsherret:perf_reduce_allocations_from_specifier
Apr 2, 2024
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
55ed743
perf: reduce allocations in MediaType::from_specifier
dsherret 25fcd94
Fix
dsherret 5b1dbdb
remove eprintln
dsherret b314b22
334ns -> 264ns
dsherret dbc6a0d
Add comment
dsherret 60fd7ea
Remove vector allocation (329ns -> 300ns)
dsherret File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
[toolchain] | ||
channel = "1.71.1" | ||
channel = "1.77.1" | ||
components = ["clippy", "rustfmt"] | ||
profile = "minimal" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be neat to have a macro that expands
"ts"
to"ts" | "TS" | "Ts" | "tS"
... seems to reduce 268ns -> 220nsEdit: or maybe something like this might be best:
...then that could be a proc macro that generates the most optimal matching strategy.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe @nathanwhit could tackle that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we could use https://doc.rust-lang.org/std/string/struct.String.html#method.eq_ignore_ascii_case instead? I think we could just create a macro that checks string length and uses that method for each case, and the compiler would be reasonably good at optimizing it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried that and it was slower than the match in this case for some reason (I think 40ns slower). It was faster for
tsbuildinfo
somewhere else in this file. Edit: Didn't try matching on string length though