Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add notice field to modules #205

Open
lucacasonato opened this issue Feb 18, 2021 · 2 comments
Open

Add notice field to modules #205

lucacasonato opened this issue Feb 18, 2021 · 2 comments
Labels
feat New feature good first issue Good for newcomers

Comments

@lucacasonato
Copy link
Member

lucacasonato commented Feb 18, 2021

Modules should get a optional notice field that can only be set manually by us. The type of this field should be string or undefined, and should not be changeable by webhooks. It should be initially unset. The field should be present in the /modules/:name api response.

This field will be used to display notices about a certain module on the deno.land/x website, for example that instead of using https://deno.land/x/istrue, you should use value === true.

@lucacasonato lucacasonato added good first issue Good for newcomers feat New feature labels Feb 18, 2021
@wperron
Copy link
Contributor

wperron commented Feb 18, 2021

I understand the impulse, I really do, but I'm hesitant to implement this -- the notice field would be applied arbitrarily by the maintainers of the registry, thus making making a judgement call on what a "good module" constitutes. If the notice was based on an objective and measurable metric I'd be much more inclined to support it (maybe sloc? number of files?)

@erfanium
Copy link

#57 May fix this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat New feature good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants