Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

registry: submodule is not handled correctly #219

Open
kt3k opened this issue Apr 14, 2021 · 5 comments
Open

registry: submodule is not handled correctly #219

kt3k opened this issue Apr 14, 2021 · 5 comments
Labels
feat New feature

Comments

@kt3k
Copy link
Member

kt3k commented Apr 14, 2021

deno_dom module has ./wpt submodule (which points to https://github.com/web-platform-tests/wpt/). When I click wpt folder in https://deno.land/x/deno_dom@v0.1.7-alpha, it shows empty page https://deno.land/x/deno_dom@v0.1.7-alpha/wpt

@wperron
Copy link
Contributor

wperron commented Apr 14, 2021

We should add a submodule option to the git clone operation in the publishing process to support this

@wperron wperron transferred this issue from denoland/dotland Apr 14, 2021
@Im-Beast
Copy link

Im-Beast commented May 8, 2021

I'm really looking forward to fix this issue, as I got very dissapointed just now figuring out that submodules are not handled correctly 😞

Im-Beast added a commit to Im-Beast/deno_registry2 that referenced this issue May 8, 2021
@wperron
Copy link
Contributor

wperron commented May 8, 2021

Well, submodules simply aren't handled at all. I've added the feat label so we can start looking into it soon. There's a couple of things to take into consideration, namely the size on disk as submodules can recurse pretty deep.

@wperron wperron added the feat New feature label May 8, 2021
@Im-Beast
Copy link

Im-Beast commented May 8, 2021

The thing is repo itself can go very deeply also without using submodules, so they're not a big problem itself. Therefore, there should just be a size limit for a module, however for bigger than desired modules it would be cool if someone could've just "link" their hosting to the system.
I don't really know how big performance gap is, so I can't really talk about that tho.

@wperron
Copy link
Contributor

wperron commented May 8, 2021

There's a logical limit of 20mb by default that we check but there's also an implicit limit because of Lambda's 512mb filesystem limit that we can't do anything about. I imagine that repos using submodules risk triggering that limit more often, but I guess we'll just have to monitor it and get some statistics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat New feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants