-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
registry: submodule is not handled correctly #219
Comments
We should add a submodule option to the git clone operation in the publishing process to support this |
I'm really looking forward to fix this issue, as I got very dissapointed just now figuring out that submodules are not handled correctly 😞 |
Well, submodules simply aren't handled at all. I've added the |
The thing is repo itself can go very deeply also without using submodules, so they're not a big problem itself. Therefore, there should just be a size limit for a module, however for bigger than desired modules it would be cool if someone could've just "link" their hosting to the system. |
There's a logical limit of 20mb by default that we check but there's also an implicit limit because of Lambda's 512mb filesystem limit that we can't do anything about. I imagine that repos using submodules risk triggering that limit more often, but I guess we'll just have to monitor it and get some statistics. |
deno_dom
module has./wpt
submodule (which points to https://github.com/web-platform-tests/wpt/). When I clickwpt
folder inhttps://deno.land/x/deno_dom@v0.1.7-alpha
, it shows empty page https://deno.land/x/deno_dom@v0.1.7-alpha/wptThe text was updated successfully, but these errors were encountered: