Skip to content

Commit

Permalink
feat(node/fs): add futimes and futimesSync (#830)
Browse files Browse the repository at this point in the history
  • Loading branch information
majidsajadi committed Apr 6, 2021
1 parent 1333c6f commit 8467929
Show file tree
Hide file tree
Showing 2 changed files with 156 additions and 0 deletions.
49 changes: 49 additions & 0 deletions node/_fs/_fs_futimes.ts
@@ -0,0 +1,49 @@
// Copyright 2018-2021 the Deno authors. All rights reserved. MIT license.
import type { CallbackWithError } from "./_fs_common.ts";

function getValidTime(
time: number | string | Date,
name: string,
): number | Date {
if (typeof time === "string") {
time = Number(time);
}

if (
typeof time === "number" &&
(Number.isNaN(time) || !Number.isFinite(time))
) {
throw new Deno.errors.InvalidData(
`invalid ${name}, must not be infitiny or NaN`,
);
}

return time;
}

export function futimes(
fd: number,
atime: number | string | Date,
mtime: number | string | Date,
callback: CallbackWithError,
): void {
if (!callback) {
throw new Deno.errors.InvalidData("No callback function supplied");
}

atime = getValidTime(atime, "atime");
mtime = getValidTime(mtime, "mtime");

Deno.futime(fd, atime, mtime).then(() => callback(null), callback);
}

export function futimesSync(
fd: number,
atime: number | string | Date,
mtime: number | string | Date,
): void {
atime = getValidTime(atime, "atime");
mtime = getValidTime(mtime, "mtime");

Deno.futimeSync(fd, atime, mtime);
}
107 changes: 107 additions & 0 deletions node/_fs/_fs_futimes_test.ts
@@ -0,0 +1,107 @@
import { assertEquals, assertThrows, fail } from "../../testing/asserts.ts";
import { futimes, futimesSync } from "./_fs_futimes.ts";

const randomDate = new Date(Date.now() + 1000);

Deno.test({
name:
"ASYNC: change the file system timestamps of the object referenced by path",
async fn() {
const file: string = Deno.makeTempFileSync();
const { rid } = await Deno.open(file, { create: true, write: true });

await new Promise<void>((resolve, reject) => {
futimes(rid, randomDate, randomDate, (err: Error | null) => {
if (err !== null) reject();
else resolve();
});
})
.then(
() => {
const fileInfo: Deno.FileInfo = Deno.lstatSync(file);
assertEquals(fileInfo.mtime, randomDate);
assertEquals(fileInfo.atime, randomDate);
},
() => {
fail("No error expected");
},
)
.finally(() => {
Deno.removeSync(file);
Deno.close(rid);
});
},
});

Deno.test({
name: "ASYNC: should throw error if atime is infinity",
fn() {
assertThrows(
() => {
futimes(123, Infinity, 0, (err: Error | null) => {});
},
Error,
"invalid atime, must not be infitiny or NaN",
);
},
});

Deno.test({
name: "ASYNC: should throw error if atime is NaN",
fn() {
assertThrows(
() => {
futimes(123, "some string", 0, (err: Error | null) => {});
},
Error,
"invalid atime, must not be infitiny or NaN",
);
},
});

Deno.test({
name:
"SYNC: change the file system timestamps of the object referenced by path",
fn() {
const file: string = Deno.makeTempFileSync();
const { rid } = Deno.openSync(file, { create: true, write: true });

try {
futimesSync(rid, randomDate, randomDate);

const fileInfo: Deno.FileInfo = Deno.lstatSync(file);

assertEquals(fileInfo.mtime, randomDate);
assertEquals(fileInfo.atime, randomDate);
} finally {
Deno.removeSync(file);
Deno.close(rid);
}
},
});

Deno.test({
name: "SYNC: should throw error if atime is NaN",
fn() {
assertThrows(
() => {
futimesSync(123, "some string", 0);
},
Error,
"invalid atime, must not be infitiny or NaN",
);
},
});

Deno.test({
name: "SYNC: should throw error if atime is Infinity",
fn() {
assertThrows(
() => {
futimesSync(123, Infinity, 0);
},
Error,
"invalid atime, must not be infitiny or NaN",
);
},
});

0 comments on commit 8467929

Please sign in to comment.