ws: use crypto getRandomValues (#584)

denoland · Sep 4, 2019 · bc7dd39 · bc7dd39
1 parent 4e21ace
commit bc7dd39
Showing 1 changed file with 1 addition and 5 deletions.
diff --git a/ws/mod.ts b/ws/mod.ts
@@ -189,11 +189,7 @@ export async function readFrame(buf: BufReader): Promise<WebSocketFrame> {
 
 // Create client-to-server mask, random 32bit number
 function createMask(): Uint8Array {
-  // TODO: use secure and immutable random function. Crypto.getRandomValues()
-  const arr = Array.from({ length: 4 }).map(
-    (): number => Math.round(Math.random() * 0xff)
-  );
-  return new Uint8Array(arr);
+  return crypto.getRandomValues(new Uint8Array(4));
 }
 
 class WebSocketImpl implements WebSocket {