Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ws module broken #441

Closed
MarkTiedemann opened this issue May 23, 2019 · 5 comments · Fixed by #550
Closed

ws module broken #441

MarkTiedemann opened this issue May 23, 2019 · 5 comments · Fixed by #550

Comments

@MarkTiedemann
Copy link
Contributor

#430 removed the conn property from ServerRequest "because it's not used anymore". However, this property is still used in acceptWebSocket (see: https://github.com/denoland/deno_std/blob/master/ws/mod.ts#L368). So the ws module is broken now.
@ry
Copy link
Member

ry commented May 23, 2019

Oops. And apparently not tested well.

@ry
Copy link
Member

ry commented May 23, 2019

We should consider
https://golang.org/pkg/net/http/#Hijacker
https://github.com/golang/net/blob/f3200d17e092c607f615320ecaad13d87ad9a2b3/websocket/server.go#L73

@MarkTiedemann MarkTiedemann mentioned this issue May 23, 2019
Closed
@irustm
Copy link
Contributor

irustm commented Jun 7, 2019

Tell me, please, what have you decided on this issue?

@josephrocca
Copy link

josephrocca commented Jul 25, 2019 •
edited
Loading

Not sure it's related to this, but when I try to run the WebSocket demo code in the readme:

error: Uncaught SyntaxError: The requested module 'https://deno.land/std/ws/mod.ts' does not provide an export named 'WebSocket'

Seems like it's there in the .ts but gone in the compiled script.

This was referenced Jul 30, 2019
Closed
Merged
@GrosSacASac GrosSacASac mentioned this issue Aug 2, 2019
Open
piscisaureus pushed a commit that referenced this issue Aug 5, 2019
@bartlomieju @piscisaureus
Revert "http: delete conn parameter in readRequest" (#550)
3e17815 
This reverts commit 209183e.
Fixes: #441
@irustm
Copy link
Contributor

irustm commented Aug 6, 2019

waiting.. release deno_std 🙏

ry pushed a commit to ry/deno that referenced this issue Oct 9, 2019
@bartlomieju @piscisaureus
Revert "http: delete conn parameter in readRequest" (denoland/std#550)
50fdccb 
This reverts commit 209183e.
Fixes: denoland/std#441
Original: denoland/std@3e17815
caspervonb pushed a commit to caspervonb/deno_std that referenced this issue Jan 24, 2021
@bartlomieju @piscisaureus
Revert "http: delete conn parameter in readRequest" (denoland#550)
93f5aec 
This reverts commit 209183e.
Fixes: denoland#441
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@ry @josephrocca @MarkTiedemann @irustm