Revert "http: delete conn parameter in readRequest (#430)" #443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 209183e.
piscisaureus
approved these changes
May 24, 2019
|
Could we get this sorted? WS support would be seriously nice to have again. |
|
Is this PR still relevant? CC @ry |
Yes, the WS module is still broken as described in #441. |
|
Can you rebase this and try to get it green? |
|
Sure |
inverted-capital
pushed a commit
to dreamcatcher-tech/napps
that referenced
this pull request
Oct 24, 2024
closes denoland#378. adds some naive url validations to the submit route. adds some tests for these naive validations. these validations check that: - the urls start w/ `http:` or `https:` - the urls don't use local ip addresses and/or `localhost` --------- Co-authored-by: Asher Gomez <ashersaupingomez@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #441
We'll have to wait to remove the conn parameter until ws is working.
This reverts commit 209183e.