Turn off canary builds, turn on stable builds. #1003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucacasonato
approved these changes
Jul 5, 2021
There was a problem hiding this comment.
Not in favor at all (stable builds don't catch incompatibilities in std like canary does). This has been an issue ever since we enabled canary on std, and I don't think keeping it enabled here for a few more hours/days until I can get it fixed in CLI is much of an issue.
|
We cannot enable canary - even trying to do it now creates a red status here. People contributing patches to deno_std should not encounter our technical debt elsewhere - they don't have the context to understand that it's not their problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.