Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: make collections examples executable #1046

Closed
wants to merge 2 commits into from
Closed

docs: make collections examples executable #1046

wants to merge 2 commits into from

Conversation

kt3k
Copy link
Member

@kt3k kt3k commented Jul 20, 2021

This PR makes the examples of collections module executable. You can copy & paste these examples in repl. (This also replaces console.assert(a === b) with assertEquals(a, b) because === equality doesn't work for arrays and objects.)

@kt3k kt3k requested a review from wperron July 21, 2021 05:17
@kt3k
Copy link
Member Author

kt3k commented Jul 21, 2021

This now conflicts with #1050. I'll re-open this after #1050.

@kt3k kt3k closed this Jul 21, 2021
@kt3k kt3k deleted the docs/update-collection-examples branch July 25, 2022 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wperron wperron Awaiting requested review from wperron

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kt3k