Adding shim for perf_hooks in deno #1088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
guybedford
reviewed
Aug 2, 2021
guybedford
approved these changes
Aug 2, 2021
There was a problem hiding this comment.
LGTM.
You can also include a README update for https://github.com/denoland/deno_std/blob/main/node/README.md#supported-builtins to note this builtin is now implemented.
JayaKrishnaNamburu
force-pushed
the
shim/perf-hooks
branch
from
dec3e1b
to
77639ce
Compare
JayaKrishnaNamburu
changed the title
kt3k
reviewed
Aug 3, 2021
JayaKrishnaNamburu
force-pushed
the
shim/perf-hooks
branch
from
8b7fad1
to
5d184c5
Compare
kt3k
approved these changes
Aug 3, 2021
There was a problem hiding this comment.
@JayaKrishnaNamburu LGTM. Thank you for your contribution!
(Note: I fixed a few type errors to pass the CI check. Please let me know if you find a problem in typing.)
|
Thank you @kt3k sure will let you know if there are any 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just upstreaming the shims that we are trying to add into
jspm-core😄. Please let me know if there are any changes needed.