Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(collections): Add withoutAll that returns an array excluding all given values #1100

Merged
merged 11 commits into from
Aug 24, 2021
Merged

feat(collections): Add withoutAll that returns an array excluding all given values #1100

merged 11 commits into from
Aug 24, 2021

Conversation

getspooky
Copy link
Contributor

Returns an array excluding all given values, For performance if given array is large size(bigger than 200) , we store values in Set datastructure.

Example:

const withoutList = withoutAll([1, 2, 3, 4, 6, 3], [1, 2], [3, 4, 6, 3]);

Discussion

Please see #1065

@LionC
Copy link
Contributor

LionC commented Aug 7, 2021

I can take a first look tonight :-)

LionC
LionC suggested changes Aug 7, 2021
View reviewed changes
collections/without_all_test.ts Show resolved Hide resolved
collections/without_all.ts Outdated Show resolved Hide resolved
collections/without_all.ts Outdated Show resolved Hide resolved
collections/without_all_test.ts Show resolved Hide resolved
@getspooky getspooky requested a review from kt3k August 17, 2021 09:30
kt3k
kt3k reviewed Aug 17, 2021
View reviewed changes
collections/without_all.ts Outdated Show resolved Hide resolved
@getspooky getspooky requested a review from kt3k August 17, 2021 14:25
LionC
LionC suggested changes Aug 17, 2021
View reviewed changes
Copy link
Contributor

@LionC LionC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the example left, the redt looks good to me

collections/without_all.ts Outdated Show resolved Hide resolved
@getspooky @LionC
Update collections/without_all.ts
9109c62 
Co-authored-by: Leon Strauss <me@lionc.de>
@kt3k kt3k mentioned this pull request Aug 21, 2021
Closed
26 tasks
@getspooky @zhangyuannie
Update collections/without_all.ts
7189b81 
Co-authored-by: Zhangyuan Nie <yuan@znie.org>
LionC
LionC approved these changes Aug 23, 2021
View reviewed changes
Copy link
Contributor

@LionC LionC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now, pinging @kt3k for re-review

kt3k
kt3k approved these changes Aug 24, 2021
View reviewed changes
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@getspooky LGTM. Nice work! Thanks!

Thanks @LionC @zhangyuannie for reviewing!

@kt3k kt3k merged commit 6c407de into denoland:main Aug 24, 2021
@getspooky getspooky mentioned this pull request Aug 24, 2021
Merged
@LionC LionC mentioned this pull request Aug 27, 2021
Closed
44 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kt3k kt3k kt3k approved these changes

@LionC LionC LionC approved these changes

@zhangyuannie zhangyuannie zhangyuannie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@getspooky @LionC @kt3k @zhangyuannie