Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(collections): add maxOf #1144

Merged
merged 15 commits into from
Aug 24, 2021
Merged

feat(collections): add maxOf #1144

merged 15 commits into from
Aug 24, 2021

Conversation

Hakizu
Copy link
Contributor

@Hakizu Hakizu commented Aug 19, 2021 •
edited
Loading

Suggestion how to implement a maxOf method

Related: #1065

@CLAassistant
Copy link

CLAassistant commented Aug 19, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@LionC
Copy link
Contributor

LionC commented Aug 19, 2021

I will add a review :-)

LionC
LionC suggested changes Aug 19, 2021
View reviewed changes
Copy link
Contributor

@LionC LionC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! I like that you included all the commonly missed things from the other PRs :-)

I think there is still some stuff to do, but this is a very good draft!

collections/max_of.ts Show resolved Hide resolved
collections/max_of.ts Outdated Show resolved Hide resolved
collections/max_of.ts Outdated Show resolved Hide resolved
collections/max_of.ts Outdated Show resolved Hide resolved
collections/max_of.ts Outdated Show resolved Hide resolved
collections/max_of.ts Outdated Show resolved Hide resolved
collections/max_of_tests.ts Outdated Show resolved Hide resolved
collections/max_of_tests.ts Show resolved Hide resolved
collections/max_of.ts Show resolved Hide resolved
LionC
LionC approved these changes Aug 19, 2021
View reviewed changes
Copy link
Contributor

@LionC LionC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Pinging @kt3k for final review :-)

@kt3k kt3k mentioned this pull request Aug 21, 2021
Closed
26 tasks
kt3k
kt3k reviewed Aug 21, 2021
View reviewed changes
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Hakizu Thank you for your contribution. Left a few comments.

collections/max_of_tests.ts Outdated Show resolved Hide resolved
collections/max_of.ts Outdated Show resolved Hide resolved
collections/max_of.ts Outdated Show resolved Hide resolved
@Hakizu
Copy link
Contributor Author

Hakizu commented Aug 22, 2021

Thanks for the feedback from both of you. I updated the PR

@Hakizu Hakizu requested a review from kt3k August 23, 2021 09:50
kt3k
kt3k approved these changes Aug 24, 2021
View reviewed changes
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Hakizu LGTM. Thank you for the contribution!

@kt3k kt3k merged commit 9379526 into denoland:main Aug 24, 2021
This was referenced Aug 25, 2021
Closed
Merged
@LionC LionC mentioned this pull request Aug 27, 2021
Closed
44 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LionC LionC LionC approved these changes

@kt3k kt3k kt3k approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Hakizu @CLAassistant @LionC @kt3k