feat(collections): add firstNotNullishOf #1167
Conversation
collections/first_not_nullish_of.ts
Outdated
| // Copyright 2018-2021 the Deno authors. All rights reserved. MIT license. | ||
|
|
||
| /** | ||
| * Returns the first value in the given collection that produces a not-nullish value using the given selector |
There was a problem hiding this comment.
I think we could simplify that language a bit maybe, the current one is a bit convoluted
There was a problem hiding this comment.
@LionC I copied the description from your proposal PR. how do you feed about Kotlin's description with a little bit of change?
Returns the first value that is neither null nor undefined produced by transform function being applied to elements of this array in iteration order, or undefined if no value was found.****
There was a problem hiding this comment.
As I noted in the proposal, the descriptions were only for the sake of internal discussion, not for actual documentation. That has been overlooked a lot, but we have to make sure it is as understandable as possible.
Maybe something like this?
Applies the given selector to elements in the given array until a value is produced that is
neither `null` nor `undefined` and returns that value.
Returns `undefined` if no such value is produced.There was a problem hiding this comment.
sounds good to me.
collections/first_not_nullish_of.ts
Outdated
| let result: NonNullable<O> | undefined = undefined; | ||
|
|
||
| for (const current of collection) { | ||
| const selected = selector(current); | ||
|
|
||
| if (selected !== null && selected !== undefined) { | ||
| result = selected as NonNullable<O>; | ||
| break; | ||
| } | ||
| } | ||
|
|
||
| return result; |
There was a problem hiding this comment.
You can actually remove the result variable completeley:
| let result: NonNullable<O> | undefined = undefined; | |
| for (const current of collection) { | |
| const selected = selector(current); | |
| if (selected !== null && selected !== undefined) { | |
| result = selected as NonNullable<O>; | |
| break; | |
| } | |
| } | |
| return result; | |
| for (const current of collection) { | |
| const selected = selector(current); | |
| if (selected !== null && selected !== undefined) { | |
| return selected as NonNullable<O>; | |
| } | |
| } | |
| return undefined; |
collections/first_not_nullish_of.ts
Outdated
| * ``` | ||
| */ | ||
| export function firstNotNullishOf<T, O>( | ||
| collection: T[], |
There was a problem hiding this comment.
Oh and we settled on array and readonly for these arguments, we should be ocnsistent here
| collection: T[], | |
| readonly array: T[], |
|
@LionC Updated. |
collections/README.md
Outdated
| ### firstNotNullishOf | ||
|
|
||
| Applies the given selector to elements in the given array until a value is | ||
| produced that is neither `null` nor `undefined` and returns that value Returns |
There was a problem hiding this comment.
Seems like a period is missing?
| produced that is neither `null` nor `undefined` and returns that value Returns | |
| produced that is neither `null` nor `undefined` and returns that value. Returns |
This PR adds
firstNotNullishOfto the collection module.