-
Notifications
You must be signed in to change notification settings - Fork 582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(collections): Add associatewith
#1213
Conversation
…and choosing a value for each key using the given selector.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the implementation! I left some comments :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@getspooky Nice work! LGTM
I'll wait a while before merging to see if there's any inputs, opinions on this because this item looks comparatively new in the proposed list. |
I think something went wrong with test : error: TS2551 [ERROR]: Property 'Signal' does not exist on type 'typeof Deno'. 'Deno.Signal' is an unstable API. Did you forget to run with the '--unstable' flag, or did you mean 'signal'?
|
@getspooky That CI error is going to be resolved in #1211, but we can't merge that fix right now because that will break stable CI. So let's just ignore canary CI for now. |
@kt3k can we merge this before the upcoming release? |
@LionC Thank you for the ping! Let's merge it. @getspooky Thanks again for the work! |
Builds a new Record using the given array as keys and choosing a value for each key using the given selector.
Related #1173