test(permissions/mod): Add invalid case #1314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wafuwafu13
commented
Sep 26, 2021
permissions/mod_test.ts
Outdated
| return grantOrThrow({ name: "nett" } as any); | ||
| }, | ||
| TypeError, | ||
| 'The provided value "nett" is not a valid permission name', |
There was a problem hiding this comment.
|
Why rename? |
|
I was wondering if the names of the logic files corresponded to the names of the test files. |
kt3k
reviewed
Sep 27, 2021
permissions/test.ts
Outdated
| Deno.test({ | ||
| name: "grantOrThrow invalid argument", | ||
| fn() { | ||
| assertThrowsAsync( |
There was a problem hiding this comment.
nit: assertThrowsAsync is now deprecated. Please use assertRejects instead
traceypooh
pushed a commit
to traceypooh/deno_std
that referenced
this pull request
Nov 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed filenametest.ts->mod_test.ts