fix(node/url): Use Class defined in node/_error.ts to throw exception
#1342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@wafuwafu13 Thank you for your contribution. Can add test cases for this fix? |
wafuwafu13
changed the title
node/_error.ts to throw exception
wafuwafu13
commented
Oct 5, 2021
| // }); | ||
| // } | ||
| // } | ||
| { |
There was a problem hiding this comment.
Can add test cases for this fix?
98cc5ae is related here.
wafuwafu13
commented
Oct 5, 2021
| } | ||
| return pathname.slice(1); | ||
| } | ||
| } | ||
|
|
||
| function getPathFromURLPosix(url: URL): string { | ||
| if (url.hostname !== "") { | ||
| throw new Deno.errors.InvalidData("invalid file url hostname"); | ||
| throw new ERR_INVALID_FILE_URL_HOST(osType); |
There was a problem hiding this comment.
traceypooh
pushed a commit
to traceypooh/deno_std
that referenced
this pull request
Nov 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #911