Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(node): add helpers for determining CJS/ESM loader #1407

Merged
merged 2 commits into from
Oct 15, 2021

Conversation

bartlomieju
Copy link
Member

These two helpers are not really part of module module,
instead they are part of lib/internal/modules/run_main.js in Node.

They are however crucial to determining which loader should
be used and I didn't want to rewrite all of this functionality in Rust if it's
already available in node/module.ts.

@bartlomieju bartlomieju requested review from AaronO and ry October 15, 2021 15:31
Copy link
Contributor

@bnoordhuis bnoordhuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ha, deja vu :-)

@bartlomieju bartlomieju merged commit 1433e32 into denoland:main Oct 15, 2021
@bartlomieju bartlomieju deleted the node_add_helpers branch October 15, 2021 15:53
traceypooh pushed a commit to traceypooh/deno_std that referenced this pull request Nov 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants