Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(node): declare 'global' types inline #1409

Merged
merged 1 commit into from
Oct 16, 2021
Merged

fix(node): declare 'global' types inline #1409

merged 1 commit into from
Oct 16, 2021

Conversation

bartlomieju
Copy link
Member

No description provided.

AaronO
AaronO approved these changes Oct 16, 2021
View reviewed changes
Copy link
Contributor

@AaronO AaronO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bartlomieju bartlomieju merged commit acd70dc into denoland:main Oct 16, 2021
@bartlomieju bartlomieju deleted the fix_node_global_types branch October 16, 2021 15:15
traceypooh pushed a commit to traceypooh/deno_std that referenced this pull request Nov 14, 2021
@bartlomieju @traceypooh
fix(node): declare 'global' types inline (denoland#1409)
2c4e7a9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ry ry ry approved these changes

@AaronO AaronO AaronO approved these changes

@kitsonk kitsonk Awaiting requested review from kitsonk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bartlomieju @ry @AaronO