-
Notifications
You must be signed in to change notification settings - Fork 576
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
strip "constructor" info for "expected befor checking in assertObjectMatch #1419
Conversation
Please add the example assertions in #1418 as test cases |
Thank you for looking into this. Left a few comments @c0per |
} | ||
assertObjectMatch({ test: new A(1) }, { test: { a: 1 } }); | ||
assertObjectMatch({ test: { a: 1 } }, { test: { a: 1 } }); | ||
assertObjectMatch({ test: { a: 1 } }, { test: new A(1) }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@c0per LGTM. Thank you for your contribution!
I didn't change the
filter
function. I just callfilter
twice to stripconstructor
info offexpected
. #1418