feat(node): provide node compatible timer APIs in commonjs wrapper #1834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
25 tasks
bnoordhuis
approved these changes
Jan 19, 2022
| "(function (exports, require, module, __filename, __dirname) { ", | ||
| // We provide non standard timer APIs in the CommonJS wrapper | ||
| // to avoid exposing them in global namespace. | ||
| "(function (exports, require, module, __filename, __dirname, setTimeout, clearTimeout, setInterval, clearInterval) { ", |
There was a problem hiding this comment.
I hope this doesn't break any third-party code...
aside: in the future we should use v8::script_compiler::compile_function_in_context() but that's not currently exposed by deno.
There was a problem hiding this comment.
We'll handle that when rewriting all of this in Rust
bartlomieju
approved these changes
Jan 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides node-compatible timer APIs in commonJS wrapper function. This works around the error
TypeError: this.peakMemoryInterval.unref is not a functionwhile executingyarnin node compatible mode. ref: https://github.com/yarnpkg/yarn/blob/3119382885ea373d3c13d6a846de743eca8c914b/src/reporters/base-reporter.js#L169part of denoland/deno#13420