feat: add fnv alg to crypto #2200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kt3k
reviewed
May 9, 2022
There was a problem hiding this comment.
@luk3skyw4lker Thank you for looking into this! Left a few comments.
|
@kt3k thanks for the review! |
|
@kt3k I think I have solved the issues. I wasn't able to keep the return of the fnv functions as ArrayBuffers because something was happening when I tried to convert the hashes into Uint32Arrays and the result was reversed (I think it may be because of MSB and LSB problems, I didn't manage to find information or fix for that) so I just convert the string to hex inside the function itself and the result comes as a hex string (and with the right ordenation). |
kt3k
reviewed
May 25, 2022
|
@kt3k I think that everything is right now! I had a lot of trouble to make the returns come as ArrayBuffers but I did it |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add implementation of fnv32, fnv32a, fnv64, fnv64a to crypto module. Addressing #2122