Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: put TextLineStream CR handling behind option #2277

Merged
merged 2 commits into from
May 29, 2022
Merged

fix: put TextLineStream CR handling behind option #2277

merged 2 commits into from
May 29, 2022

Conversation

crowlKats
Copy link
Member

@crowlKats
Copy link
Member Author

Though i guess this is a breaking change now as well...

jsejcksn
jsejcksn approved these changes May 27, 2022
View reviewed changes
Copy link
Contributor

@jsejcksn jsejcksn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @crowlKats!

kt3k
kt3k approved these changes May 28, 2022
View reviewed changes
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crowlKats crowlKats merged commit b84c4eb into denoland:main May 29, 2022
@crowlKats crowlKats deleted the put_CR_behind_opt branch June 1, 2022 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kt3k kt3k kt3k approved these changes

@jsejcksn jsejcksn jsejcksn approved these changes

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@crowlKats @kt3k @jsejcksn @bartlomieju