Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor(collections): rename RBTree and BSTree #2400

Merged
merged 7 commits into from
Jun 30, 2022
Merged

Refactor(collections): rename RBTree and BSTree #2400

merged 7 commits into from
Jun 30, 2022

Conversation

timreichen
Copy link
Contributor

  • renames RBNode to RedBlackNode and deprecates RBNode
  • renames RBTree to RedBlackTree and deprecates RBTree
  • renames BSNode to BinarySearchNode and deprecates BSNode
  • renames BSTree to BinarySearchTree and deprecates BSTree
  • renames direction type to Direction and deprecates direction

@timreichen timreichen mentioned this pull request Jun 28, 2022
Closed
kt3k
kt3k approved these changes Jun 29, 2022
View reviewed changes
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kt3k
Copy link
Member

kt3k commented Jun 29, 2022

@KyleJune Do you have any concern on this change?

@KyleJune
Copy link
Contributor

I do not have any concerns with this change. Although since the original names are deprecated, I believe the places they are used in std should be updated. The only file I'm aware of that needs updated is this one.

https://github.com/denoland/deno_std/blob/main/testing/time.ts

@kt3k kt3k merged commit 81da62d into denoland:main Jun 30, 2022
@kt3k kt3k mentioned this pull request Jun 30, 2022
Closed
@kt3k
Copy link
Member

kt3k commented Jun 30, 2022

Created an issue for remaining task #2404

@timreichen timreichen deleted the refactor(collections)--RBTree-BSTree branch June 30, 2022 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kt3k kt3k kt3k approved these changes

@bartlomieju bartlomieju Awaiting requested review from bartlomieju

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@timreichen @kt3k @KyleJune