Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(node/fs): fix accessSync permission handling #2570

Merged
merged 2 commits into from
Aug 26, 2022

Conversation

kt3k
Copy link
Member

@kt3k kt3k commented Aug 26, 2022

This PR fixes the permission handling of accessSync when the process uid is the owner of the given file.

@kt3k kt3k requested a review from bartlomieju as a code owner August 26, 2022 09:37
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for looking into this!

@kt3k
Copy link
Member Author

kt3k commented Aug 26, 2022

@bartlomieju Please 'approve'! :)

@kt3k kt3k merged commit 36fa687 into denoland:main Aug 26, 2022
@kt3k kt3k deleted the fix-node-fs-access-sync branch August 26, 2022 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants