Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BREAKING(dotenv): rename config to load #2616

Merged
merged 9 commits into from
Dec 5, 2022
Merged

BREAKING(dotenv): rename config to load #2616

merged 9 commits into from
Dec 5, 2022

Conversation

timreichen
Copy link
Contributor

@timreichen timreichen commented Sep 5, 2022 •
edited
Loading

Remake of #2416 as it was closed by accident.

  • deprecates config
  • depreactes configSync
  • deprecates ConfigOptions
  • adds load and loadSync which work the same as config and configSync but take LoadOptions
  • adds LoadOptions which renames path to envPath, defaults to defaultsPath and example to examplePath for more clarity.
  • removes the safe option as it will always use safe mode except when examplePath is absent.

@timreichen timreichen closed this Nov 15, 2022
@timreichen timreichen reopened this Nov 15, 2022
@kt3k kt3k changed the title feat(dotenv): load BREAKING(dotenv): rename config to load Nov 18, 2022
@timreichen
Copy link
Contributor Author

@kt3k ready for review

kt3k
kt3k approved these changes Dec 5, 2022
View reviewed changes
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The community looks supportive to this change (regarding Discord reactions). I'm also in favor of this change. load sounds more appropriate word for this functionality than config.

Thanks for your suggestion!

LGTM

@kt3k kt3k merged commit 3baa3da into denoland:main Dec 5, 2022
@timreichen timreichen deleted the dotenv_load branch December 5, 2022 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kt3k kt3k kt3k approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@timreichen @kt3k