perf(encoding/yaml) Don't allocate buffers unnecessarily #2967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
cscheid
added a commit
to quarto-dev/quarto-cli
that referenced
this pull request
Dec 1, 2022
cjihrig
reviewed
Dec 5, 2022
cjihrig
reviewed
Dec 5, 2022
cjihrig
reviewed
Dec 5, 2022
cscheid
added a commit
to quarto-dev/quarto-cli
that referenced
this pull request
Dec 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
isBinaryis called for every object that is encoded in yaml. Currently, it works by attempting to read from every object inside a generictry {} catch {}block, but that incurs allocation of a Buffer object and at least two Uint8Arrays in buf.readFromSync before the exception is thrown. In workloads that are heavy in yaml serialization this adds up.Over at https://quarto.org, the PR I'm submitting by itself improves our total running time by 10% by simply checking the types more conservatively ahead of attempting to read from the buffer.