Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(encoding): base58 decoding #2982

Merged
merged 4 commits into from
Dec 13, 2022
Merged

fix(encoding): base58 decoding #2982

merged 4 commits into from
Dec 13, 2022

Conversation

kratico
Copy link
Contributor

@kratico kratico commented Dec 5, 2022 •
edited

Fix base58 encoding logic

The following was filtering filter 0s and undefineds because 0 is falsy in .filter

const validOutput = output.filter((item) => item ?? false);

@kratico kratico requested a review from kt3k as a code owner December 5, 2022 17:33
@CLAassistant
Copy link

CLAassistant commented Dec 5, 2022 •
edited

CLA assistant check
All committers have signed the CLA.

@lino-levan
Copy link
Contributor

lino-levan commented Dec 5, 2022 •
edited

LGTM. Unbelievably subtle bug. Nice catch!

kt3k
kt3k approved these changes Dec 13, 2022
View reviewed changes
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@kt3k kt3k merged commit 01696ce into denoland:main Dec 13, 2022
@kt3k kt3k changed the title fix(encoding): base58 encoding fix(encoding): base58 decoding Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kt3k kt3k kt3k approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kratico @CLAassistant @lino-levan @kt3k