fix(node): do not buffer first chunk #2989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kt3k
force-pushed
the
fix-node-http-first-chunk
branch
from
6090f62
to
e8d6d4a
Compare
bartlomieju
approved these changes
Dec 8, 2022
bartlomieju
added a commit
to bartlomieju/deno_std
that referenced
this pull request
Dec 16, 2022
This reverts commit eca4dbf.
bartlomieju
added a commit
that referenced
this pull request
Dec 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates http ServerResponse class.
Currently the first chunk of server responses are buffered in the private field
#firstChunkto addcontent-type: text/plain;charset=UTF-8automatically when the only chunk is string (only on non flash-backed implementation). This behavior is not tested anywhere and it seems only causing the issue (denoland/deno#16929). This PR removes this buffering behavior, and now the server always responds the first chunk immediately.closes denoland/deno#16929