Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(node): Ignore NotSupported errors coming from Deno.chmod #2996

Merged
merged 4 commits into from
Dec 13, 2022
Merged

fix(node): Ignore NotSupported errors coming from Deno.chmod #2996

merged 4 commits into from
Dec 13, 2022
+87 −12

Conversation

ayame113
Copy link
Contributor

@ayame113 ayame113 commented Dec 10, 2022 •
edited

close #2995

@ayame113 ayame113 requested a review from kt3k as a code owner December 10, 2022 10:43
@ayame113 ayame113 closed this Dec 10, 2022
@ayame113 ayame113 reopened this Dec 10, 2022
ayame113
ayame113 commented Dec 11, 2022
View reviewed changes
node/_tools/config.json Outdated Show resolved Hide resolved
kt3k
kt3k approved these changes Dec 13, 2022
View reviewed changes
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nice!

@kt3k kt3k merged commit 5c2da66 into denoland:main Dec 13, 2022
@ayame113 ayame113 deleted the fix-chmod-error branch December 14, 2022 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kt3k kt3k kt3k approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

node: Error when running deno run -A npm:firebase-tools
2 participants
@ayame113 @kt3k