Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(flags): parse method looses types in certain cases with collect option #3040

Merged
merged 6 commits into from
Dec 23, 2022
Merged

fix(flags): parse method looses types in certain cases with collect option #3040

merged 6 commits into from
Dec 23, 2022

Conversation

c4spar
Copy link
Contributor

@c4spar c4spar commented Dec 22, 2022

close #3012

@c4spar c4spar requested a review from kt3k as a code owner December 22, 2022 14:37
@lino-levan
Copy link
Contributor

lino-levan commented Dec 22, 2022 •
edited
Loading

This is some pretty impressive typescript. Thank you for picking this up

@lino-levan
Copy link
Contributor

LGTM

kt3k
kt3k approved these changes Dec 23, 2022
View reviewed changes
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks! @c4spar

@kt3k kt3k merged commit 702f5b7 into denoland:main Dec 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kt3k kt3k kt3k approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: std/flags parse loses typing when collect and string are defined
3 participants
@c4spar @lino-levan @kt3k