Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Do not mutate tokens when creating details #3049

Merged
merged 2 commits into from
Dec 25, 2022

Conversation

kamilogorek
Copy link
Contributor

Input:

import { assertEquals } from "https://deno.land/std@0.166.0/testing/asserts.ts";

assertEquals(`foo bar`, `fooo baz`);

Before:

-   foo bar
+   fooobaz

After:

-   foo bar
+   fooo baz

Input:

import { assertEquals } from "https://deno.land/std@0.166.0/testing/asserts.ts";

assertEquals(`foo bar`, `foo baz`);

Before/after:

-   foo bar
+   foo baz

@CLAassistant
Copy link

CLAassistant commented Dec 23, 2022

CLA assistant check
All committers have signed the CLA.

@kamilogorek
Copy link
Contributor Author

Oh, thanks @kt3k

Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@kt3k kt3k merged commit 4db14f6 into denoland:main Dec 25, 2022
@kamilogorek kamilogorek deleted the details-mutation branch December 25, 2022 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants