Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Corrected slice() method of BytesList class and added 2 tests #3292

Merged
merged 4 commits into from
Apr 3, 2023
Merged

Corrected slice() method of BytesList class and added 2 tests #3292

merged 4 commits into from
Apr 3, 2023

Conversation

parischap
Copy link
Contributor

Should correct issue #3291 :

  • corrected the slice() method of the BytesList class in bytes/bytes_list.ts
  • added 2 tests in bytes/bytes_lists_test.ts

@parischap parischap requested a review from kt3k as a code owner March 29, 2023 10:23
@CLAassistant
Copy link

CLAassistant commented Mar 29, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@parischap parischap mentioned this pull request Mar 29, 2023
Closed
kt3k
kt3k approved these changes Apr 3, 2023
View reviewed changes
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Good catch! Thanks

@kt3k kt3k merged commit 06e84de into denoland:main Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kt3k kt3k kt3k approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@parischap @CLAassistant @kt3k