-
Notifications
You must be signed in to change notification settings - Fork 576
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BREAKING(semver): rewrite semver #3385
Conversation
…ure/semver-immutable
Co-authored-by: Jesse Jackson <jsejcksn@users.noreply.github.com>
…ure/semver-immutable
This should be ready now. Renamed |
Co-authored-by: Tim Reichen <timreichen@users.noreply.github.com>
Co-authored-by: Tim Reichen <timreichen@users.noreply.github.com>
Summary of changes:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While I haven't reviewed the actual implementation, I read through the API changes. The is gonna be quite a breakage for users, but I think it's for the better - it makes it way more obvious which operations are more costly and requires more care from the user.
LGTM
semver/gt.ts
Outdated
s1: SemVer, | ||
): boolean; | ||
/** | ||
* @deprecated (will be removed after 0.195.0) Use `gt(s0: SemVer, s1: SemVer)` instead. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's great that the backwards compatibility is still preserver for know - I suggest we give it anywhere between 1-3 months before removing the deprecated API.
So maybe let's be more generous here and deprecate in 0.200.0
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
0.200.0 sounds good to me 👍 Updated
continuation of #3169.
This PR rewrites
semver
module, and makeSemVer
object immutable.Remaining tasks. We needs to restore deprecated signatures to the below APIs:
intersects
maxSatisfying
minSatisfying
minVersion
toComparators
validRange
closes #3164