Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(examples): remove examples folder #3546

Merged
merged 2 commits into from
Aug 18, 2023

Conversation

lino-levan
Copy link
Contributor

Closes #3463. Do we want to move these somewhere? Maybe a new category can be added to denobyexample for "complete app examples" or something? Maybe these make more sense in the manual?

@github-actions github-actions bot added the fmt label Aug 17, 2023
@kt3k
Copy link
Member

kt3k commented Aug 18, 2023

This change looks fine to me at this point. We have https://examples.deno.land/ and https://github.com/denoland/examples . Those work better as the collections of examples.

Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kt3k
Copy link
Member

kt3k commented Aug 18, 2023

I'll label this as chore as these have never been intended as public APIs of std.

@kt3k kt3k changed the title BREAKING(examples): remove examples folder chore(examples): remove examples folder Aug 18, 2023
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kt3k kt3k merged commit 01d45f1 into denoland:main Aug 18, 2023
9 checks passed
@lino-levan lino-levan deleted the breaking-remove-examples branch August 18, 2023 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Moving the examples directory
3 participants