Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(http/cookie): Remove dependency to std/datetime #3624

Closed
wants to merge 2 commits into from
Closed

fix(http/cookie): Remove dependency to std/datetime #3624

wants to merge 2 commits into from

Conversation

babiabeo
Copy link
Contributor

@babiabeo babiabeo commented Sep 5, 2023

Fixes: #3623

@babiabeo babiabeo requested a review from kt3k as a code owner September 5, 2023 14:35
@github-actions github-actions bot added the http label Sep 5, 2023
@0f-0b
Copy link
Contributor

0f-0b commented Sep 5, 2023

Can toIMF(date) be replaced with date.toUTCString()?

@babiabeo babiabeo closed this Sep 5, 2023
@lino-levan
Copy link
Contributor

@babiabeo Is there a reason you closed this PR?

@babiabeo
Copy link
Contributor Author

babiabeo commented Sep 9, 2023 •
edited
Loading

@babiabeo Is there a reason you closed this PR?

Something went wrong that I couldn't commit the change in this PR

@babiabeo babiabeo mentioned this pull request Sep 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kt3k kt3k Awaiting requested review from kt3k kt3k is a code owner

Assignees
No one assigned
Labels
http
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove dependency to std/datetime from std/http/cookie
3 participants
@babiabeo @0f-0b @lino-levan