Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Add expect syntax by wrapping assert syntax #3627

Closed
wants to merge 14 commits into from

Conversation

Sorikairox and others added 9 commits September 7, 2023 15:21
to__strict_equal.ts
to_be.ts
to_be_defined.ts
to_be_greater.ts
to_be_greater_or_equal.ts
to_be_instance_of.ts
to_be_less.ts
to_be_less_or_equal.ts
to_be_nan.ts
to_be_null.ts
to_be_undefined.ts
to_equal.ts
to_equal_test.ts
to_match.ts
to_match_object.ts
to_throw.ts
@Sorikairox
Copy link
Contributor Author

If anyone has any clue on what the following error mean:

Run deno task lint:deprecations
Task lint:deprecations deno run --allow-read --allow-net ./_tools/check_deprecation.ts
Download https://deno.land/x/deno_doc@0.59.0/mod.ts
Download https://deno.land/x/deno_doc@0.59.0/lib/deno_doc.generated.js
Download https://deno.land/x/deno_graph@0.[4](https://github.com/denoland/deno_std/actions/runs/6106288969/job/16571102052?pr=3627#step:7:5)[5](https://github.com/denoland/deno_std/actions/runs/6106288969/job/16571102052?pr=3627#step:7:6).0/lib/loader.ts
error: Uncaught (in promise) Error: ../../assert/assertion_error
      const ret = new Error(getStringFromWasm0(arg0, arg1));
                  ^
    at __wbg_new_15d39[6](https://github.com/denoland/deno_std/actions/runs/6106288969/job/16571102052?pr=3627#step:7:7)6e9981a196 (https://deno.land/x/deno_doc@0.59.0/lib/deno_doc.generated.js:498:19)
    at <anonymous> (https://deno.land/x/deno_doc@0.59.0/lib/deno_doc_bg.wasm:1:2056[7](https://github.com/denoland/deno_std/actions/runs/6106288969/job/16571102052?pr=3627#step:7:8)[8](https://github.com/denoland/deno_std/actions/runs/6106288969/job/16571102052?pr=3627#step:7:9)1)
    at <anonymous> (https://deno.land/x/deno_doc@0.5[9](https://github.com/denoland/deno_std/actions/runs/6106288969/job/16571102052?pr=3627#step:7:10).0/lib/deno_doc_bg.wasm:1:1509332)
    at <anonymous> (https://deno.land/x/deno_doc@0.59.0/lib/deno_doc_bg.wasm:1:1522600)
    at <anonymous> (https://deno.land/x/deno_doc@0.59.0/lib/deno_doc_bg.wasm:1:2008543)
    at __wbg_adapter_46 (https://deno.land/x/deno_doc@0.59.0/lib/deno_doc.generated.js:231:6)
    at real (https://deno.land/x/deno_doc@0.59.0/lib/deno_doc.generated.js:215:14)
    at eventLoopTick (ext:core/01_core.js:183:[11](https://github.com/denoland/deno_std/actions/runs/6106288969/job/16571102052?pr=3627#step:7:12))
Error: Process completed with exit code 1.```

testing/_matchers/to_be_falsy.ts Outdated Show resolved Hide resolved
testing/_matchers/to_be_close_to.ts Outdated Show resolved Hide resolved
testing/_matchers/to_be_truthy.ts Outdated Show resolved Hide resolved
@@ -2,7 +2,7 @@
import { AssertionError } from "./assertion_error.ts";

// deno-lint-ignore no-explicit-any
type AnyConstructor = new (...args: any[]) => any;
export type AnyConstructor = new (...args: any[]) => any;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's not export this, but copy it into expect.ts to avoid increasing the public types.

@kt3k
Copy link
Member

kt3k commented Sep 7, 2023

If anyone has any clue on what the following error mean:

Looks like the error caused by import specifiers without .ts extension. (The error message looks too unfriendly though (Created an issue in deno_doc denoland/deno_doc#348 ))

Sorikairox and others added 3 commits September 8, 2023 10:07
Co-authored-by: Yoshiya Hinosawa <stibium121@gmail.com>
Co-authored-by: Yoshiya Hinosawa <stibium121@gmail.com>
Co-authored-by: Yoshiya Hinosawa <stibium121@gmail.com>
@Sorikairox Sorikairox changed the title Feat: Add expect syntax by wrapper assert syntax Feat: Add expect syntax by wrapping assert syntax Sep 8, 2023
@iuioiua
Copy link
Collaborator

iuioiua commented Nov 13, 2023

Hi @Sorikairox, is this PR ready to merge or did you need a hand with anything?

@kt3k
Copy link
Member

kt3k commented Nov 16, 2023

Thanks for working on this @Sorikairox

We'll continue the rest of tasks in other branch!

@kt3k kt3k mentioned this pull request Nov 16, 2023
18 tasks
@kt3k
Copy link
Member

kt3k commented Nov 16, 2023

We opened #3814 for continuing the work.

@kt3k kt3k closed this Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants