-
Notifications
You must be signed in to change notification settings - Fork 596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(front_matter): Move exports to their own module #3634
fix(front_matter): Move exports to their own module #3634
Conversation
front_matter/createExtractor.ts
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's use snake_case for file names
front_matter/formats.ts
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd suggest we should keep this private (i.e. prefix the file name with _
) as this looks exposing too much internal details.)
Thanks for the PR. Mostly looks good to me. Left a few comments |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
Cleaning up front_matter per #3601. Moved
createExtractor
andtest
to their own modules. Copied tests into respective test files.I'm looking for guidance because in trying to recycle the regex patterns by moving them to a
formats
module, we technically have two exports there.