Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(datetime): Correctly format midnight in 12-hour time #3667

Merged
merged 1 commit into from
Sep 22, 2023
Merged

fix(datetime): Correctly format midnight in 12-hour time #3667

merged 1 commit into from
Sep 22, 2023

Conversation

alexanderreiff
Copy link
Contributor

@alexanderreiff alexanderreiff commented Sep 21, 2023 •
edited

I found that a Date object in the midnight hour will be formatted as 0:xx in a hmm date time format.

Deno's datetime.format documentation for h/hh says this should be from 1-12, as does the underlying Unicode specification.

@CLAassistant
Copy link

CLAassistant commented Sep 21, 2023 •
edited

CLA assistant check
All committers have signed the CLA.

kt3k
kt3k approved these changes Sep 22, 2023
View reviewed changes
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@kt3k kt3k merged commit 9d92232 into denoland:main Sep 22, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kt3k kt3k kt3k approved these changes

Assignees
No one assigned
Labels
datetime
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alexanderreiff @CLAassistant @kt3k