feat: std/data_structures
#3734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any suggestion, objection, bikeshedding, etc from the community is welcome. |
|
There seems to be no concern. |
|
I've corrected the removal version. |
Merged
|
Let me try some bike shedding. How about singular form: @KyleJune Do you have any other/better ideas for this new submodule name? |
|
I think |
|
Of the two, my preference would be std/data_structures to make it clear there are many. std/collections is also plural. |
kwj
added a commit
to kwj/project-euler
that referenced
this pull request
Dec 17, 2023
Move `BinaryHeap` in std/collections to std/data_structures ref: denoland/std#3734
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change moves the unstable
BinaryHeap(),BinarySearchTree(),ascend(),descend()andRedBlackTree()APIs to the newstd/data_structuressub-module. After a discussion with @kt3k, we decided this location for these APIs makes the most sense. This will also open up opportunities for more data-structure-related APIs in the future.The unstable files within
std/collectionswere deleted, as they were... unstable. I've updated and cleaned up the previous deprecation documentation and added the sub-module to CI processes, etc.