Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING: stabilise std/http/methods #3738

Closed
wants to merge 4 commits into from
Closed

Conversation

iuioiua
Copy link
Collaborator

@iuioiua iuioiua commented Oct 28, 2023

Another list of HTTP methods worth considering is this. However, I think it's best to support the commonly used HTTP methods initially and only expand to include the uncommonly used ones if there's demand for them.

This is a continuation of #3655.

@iuioiua iuioiua marked this pull request as ready for review October 31, 2023 11:07
@iuioiua iuioiua requested a review from kt3k as a code owner October 31, 2023 11:07
@kt3k
Copy link
Member

kt3k commented Nov 11, 2023

I have a few questions about this.

In what case is this module useful? I've never needed this kind of check (isHttpMethod) or list (HTTP_METHODS) in web development. What is the valid use case?

I think it's best to support the commonly used HTTP methods initially

I don't see enough motivation to limit them to ones mentioned in rfc 9110. rfc 9110 says:

Additional methods, outside the scope of this specification, have been specified for use in HTTP. All such methods ought to be registered within the "Hypertext Transfer Protocol (HTTP) Method Registry", as described in Section 16.1.

So the ones in HTTP method registry are also HTTP methods. Why do we exclude them?

expand to include the uncommonly used ones if there's demand for them.

Any such change is going to be a breaking change (as isHttpMethod returns different values) and requires major version bump of std/http after v1. Is that acceptable situation?

@iuioiua
Copy link
Collaborator Author

iuioiua commented Nov 12, 2023

Hm... Now that you say it, I don't think this file has a valid use case. What do usage data say? We can also ask the community on Discord. Let's confirm it's even needed in the first place before proceeding to discuss these changes.

@iuioiua
Copy link
Collaborator Author

iuioiua commented Nov 14, 2023

Hm... Perhaps, we should just deprecate then remove this file: https://discord.com/channels/684898665143206084/775393009981849600/1173370592003625090

@iuioiua
Copy link
Collaborator Author

iuioiua commented Nov 21, 2023

Closing in favour of #3834 for now.

@iuioiua iuioiua closed this Nov 21, 2023
@iuioiua iuioiua deleted the stabilise-http-methods branch November 21, 2023 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants