Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deprecation(semver): deprecate testComparator() #4037

Merged
merged 3 commits into from Dec 28, 2023
Merged

deprecation(semver): deprecate testComparator() #4037

merged 3 commits into from Dec 28, 2023

Conversation

timreichen
Copy link
Contributor

deprecates testComparator in favour of using compare.

kt3k
kt3k approved these changes Dec 28, 2023
View reviewed changes
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I now wonder if Comparator interface is useful/meaningful to the user at all

iuioiua
iuioiua reviewed Dec 28, 2023
View reviewed changes
semver/test_comparator.ts Outdated Show resolved Hide resolved
@iuioiua
Copy link
Collaborator

iuioiua commented Dec 28, 2023

I now wonder if Comparator interface is useful/meaningful to the user at all

Let's explore that idea if we haven't already. CC @timreichen

iuioiua
iuioiua approved these changes Dec 28, 2023
View reviewed changes
Copy link
Collaborator

@iuioiua iuioiua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, Tim!

@iuioiua iuioiua changed the title deprecation(semver): deprecate testComparator deprecation(semver): deprecate testComparator() Dec 28, 2023
@iuioiua iuioiua merged commit 7a0294a into denoland:main Dec 28, 2023
12 checks passed
This was referenced Jan 1, 2024
Open
Closed
@timreichen timreichen deleted the semver_deprecate_test_comparator branch January 7, 2024 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kt3k kt3k kt3k approved these changes

@iuioiua iuioiua iuioiua approved these changes

Assignees
No one assigned
Labels
semver
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@timreichen @iuioiua @kt3k